Use sonnet 4.6 as default in anthropic#2786
Merged
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The production-code change is correct and well-scoped — bumping DefaultModels["anthropic"] from "claude-sonnet-4-5" to "claude-sonnet-4-6".
ℹ️ Note: test file needs updating
pkg/config/auto_test.go still hardcodes "claude-sonnet-4-5" in several places that test the default model value:
| Location | Test |
|---|---|
| line 171 | TestAutoModelConfig – "anthropic provider" subcase |
| line 213 | TestAutoModelConfig – "gateway defaults to anthropic" subcase |
| line 291 | TestDefaultModels – direct assert.Equal(t, "claude-sonnet-4-5", DefaultModels["anthropic"]) |
| line 442 | TestAutoModelConfig_UserDefaultModel – "empty model falls back to auto detection" subcase |
These assertions depend on DefaultModels["anthropic"] returning the old value and will fail with task test as-is. (Lines 469/477 in the same file set "claude-sonnet-4-5" as an explicit user-supplied model and are unaffected — they test that user-provided models are preserved, not the default.)
Member
|
@rumpl It's in the tests too |
Member
Author
fixed |
Member
Author
|
OMG HOW MANY TIMES ARE WE CHECKING FOR THIS |
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
dgageot
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same price, better model